Added $connection property to class

maxalmonte14 commented 5 years ago

Description (*)

This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/137

Fixed Issues (if relevant)

https://github.com/magento-engcom/import-export-improvements/issues/137: Clean Up Helper/Uploader.php

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse app/code/Magento/DownloadableImportExport/Helper/Uploader.php as described in https://github.com/magento-engcom/import-export-improvements/issues/137, after this implementation the following errors shouldn't be present

------ --------------------------------------------------------------------------------------------------------------------------------
  Line   Uploader.php
 ------ --------------------------------------------------------------------------------------------------------------------------------
  63     Access to an undefined property Magento\DownloadableImportExport\Helper\Uploader::$connection.
 ------ --------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 5 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

maxalmonte14 commented 5 years ago

Done. Interesting approach by the way!

magento-engcom / import-export-improvements