Closed maxalmonte14 closed 5 years ago
Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.
I extracted the $websiteString
to a local variable inside the testGetAllWebsitesValue
method, also I made sure the test is passing by running ./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/Validator/WebsiteTest.php
👍
Description (*)
This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/132
Fixed Issues (if relevant)
Manual testing scenarios (*)
./vendor/bin/phpstan analyse app/code/Magento/AdvancedPricingImportExport/Test/Unit/Model/Import/AdvancedPricing/Validator/WebsiteTest.php
as described in https://github.com/magento-engcom/import-export-improvements/issues/132, after this implementation the following error shouldn't be presentContribution checklist (*)