magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Fixed miss called property in getStoreIdByCode method #143

Closed maxalmonte14 closed 5 years ago

maxalmonte14 commented 5 years ago

Description (*)

This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/134

Fixed Issues (if relevant)

  1. https://github.com/magento-engcom/import-export-improvements/issues/134: Clean up Model/Import/Product/Type/Bundle.php

Manual testing scenarios (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php as described in https://github.com/magento-engcom/import-export-improvements/issues/134, after this implementation the following error shouldn't be present
------ ------------------------------------------------------------------------------------------------------------------------------------------
  Line   Bundle.php
 ------ ------------------------------------------------------------------------------------------------------------------------------------------
  782    Access to an undefined property Magento\BundleImportExport\Model\Import\Product\Type\Bundle::$storeIdToCode.
 ------ ------------------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

dmanners commented 5 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

magento-engcom-team commented 5 years ago

@maxalmonte14 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

dmanners commented 5 years ago

Hi @maxalmonte14 I push 1 commit to this branch (https://github.com/magento-engcom/import-export-improvements/pull/143/commits/b552406f8e1bd7cc5b33b37bdc4e8b757883e0de) to fix some php code style issues.

maxalmonte14 commented 5 years ago

@dmanners excellent 👌