Added $_customerCollection property to Storage class

maxalmonte14 commented 5 years ago

Description (*)

This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/135

Fixed Issues (if relevant)

https://github.com/magento-engcom/import-export-improvements/issues/135: Clean up Model/ResourceModel/Import/Customer/Storage.php

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse app/code/Magento/CustomerImportExport/Model/ResourceModel/Import/Customer/Storage.php as described in https://github.com/magento-engcom/import-export-improvements/issues/135, after this implementation the following error shouldn't be present

------ -----------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Storage.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------
  61     Access to an undefined property Magento\CustomerImportExport\Model\ResourceModel\Import\Customer\Storage::$_customerCollection.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 5 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

maxalmonte14 commented 5 years ago

Done, I removed the unused properties and made sure that StorageTest.php is passing, by running vendor/bin/phpunit app/code/Magento/CustomerImportExport/Test/Unit/Model/ResourceModel/Import/Customer/StorageTest.php 👍

dmanners commented 5 years ago

Nice @maxalmonte14 I will update our tools and progress this.

maxalmonte14 commented 5 years ago

I added back the customerCollectionFactory property to the class and the parameter to the constructor method, I didn't realize the mistake in the first place, sorry!

magento-engcom / import-export-improvements