Closed maxalmonte14 closed 5 years ago
Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.
Done, I removed the unused properties and made sure that StorageTest.php
is passing, by running vendor/bin/phpunit app/code/Magento/CustomerImportExport/Test/Unit/Model/ResourceModel/Import/Customer/StorageTest.php
👍
Nice @maxalmonte14 I will update our tools and progress this.
I added back the customerCollectionFactory
property to the class and the parameter to the constructor method, I didn't realize the mistake in the first place, sorry!
Description (*)
This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/135
Fixed Issues (if relevant)
Manual testing scenarios (*)
./vendor/bin/phpstan analyse app/code/Magento/CustomerImportExport/Model/ResourceModel/Import/Customer/Storage.php
as described in https://github.com/magento-engcom/import-export-improvements/issues/135, after this implementation the following error shouldn't be presentContribution checklist (*)