Cleaned Up Test/Unit/Model/Import/Product/Type/ConfigurableTest.php

maxalmonte14 commented 6 years ago

Description (*)

This PR solves the problem addressed in https://github.com/magento-engcom/import-export-improvements/issues/131

Fixed Issues (if relevant)

https://github.com/magento-engcom/import-export-improvements/issues/131: Clean Up Test/Unit/Model/Import/Product/Type/ConfigurableTest.php

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse app/code/Magento/ConfigurableImportExport/Test/Unit/Model/Import/Product/Type/ConfigurableTest.php as described in https://github.com/magento-engcom/import-export-improvements/issues/131, after this implementation the following errors shouldn't be present

------ ---------------------------------------------------------------------------------------------------------------------------------------------
  Line   ConfigurableTest.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
  401    Array has 2 duplicate keys with value 'is_static' ('is_static', 'is_static').
  423    Array has 2 duplicate keys with value 'is_static' ('is_static', 'is_static').
  611    Access to an undefined property Magento\ConfigurableImportExport\Test\Unit\Model\Import\Product\Type\ConfigurableTest::$_oldSku.
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 6 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

kokoc commented 5 years ago

cleanup make sense for me

dmanners commented 5 years ago

Thank you for your effort here. As we are focusing import work on the async-import project we will be closing this project for now.

ghost commented 5 years ago

Hi @maxalmonte14, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom / import-export-improvements