Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download - Githubissues

magento-engcom / import-export-improvements

Open Software License 3.0

31 stars 29 forks source link

Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download #148

Closed denispapec closed 5 years ago

denispapec commented 5 years ago

Description (*)

This PR solves phpstan error by having defined $fileFactory variable.

Fixed Issues (if relevant)

magento-engcom/import-export-improvements#126: Clean Up Magento/ImportExport/Controller/Adminhtml/History/Download

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Controller/Adminhtml/History/Download.php
Expected result: No errors

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 commented 5 years ago

All committers have signed the CLA.

dmanners commented 5 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.