Removed parameter from constructor inside CustomTest class - Githubissues

magento-engcom / import-export-improvements

Open Software License 3.0

31 stars 29 forks source link

Removed parameter from constructor inside CustomTest class #149

Closed denispapec closed 5 years ago

denispapec commented 5 years ago

Description (*)

this PR solves phpstan error by having parameter inside constructor removed.

Fixed Issues (if relevant)

magento-engcom/import-export-improvements#123: Call to Magento\ImportExport\Model\Source\Import\Behavior\Custom with constructor arguments

Manual testing scenarios (*)

./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Test/Unit/Model/Source/Import/Behavior/CustomTest.php
Expected result: No errors

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 5 years ago

Thanks @denispapec for this PR. It looks good. I will start to process this PR now.

magento-engcom-team commented 5 years ago

@denispapec thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.