Define $session property in History model - Githubissues

magento-engcom / import-export-improvements

Open Software License 3.0

31 stars 29 forks source link

Define $session property in History model #150

Closed denispapec closed 5 years ago

denispapec commented 5 years ago

Description (*)

this PR solves phpstan error by having $session property defined.

Fixed Issues (if relevant)

magento-engcom/import-export-improvements#122: Cleanup History file

Manual testing scenarios (*)

run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/History.php
Expected result: no errors.

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

dmanners commented 5 years ago

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.