Closed Stepa4man closed 5 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Hi @Stepa4man could you check the git user to make sure it matched your github user and sign the CLA.
Also please take a look at my feedback and the untitest failures.
https://travis-ci.org/magento-engcom/import-export-improvements/jobs/447558203
Hey @dmanners, thanks for your comments. I'll take a look and fix/answer as soon as possible.
So @Stepa4man thanks for the update. Let me take a look at the unit tests and see what I can find out. Currently there is the following errors.
There were 2 errors:
1) Magento\CatalogImportExport\Test\Unit\Model\Import\UploaderTest::testMoveFileUrl with data set #0 ('http://test_uploader_file', 'test_uploader_file', 'test_uploader_file')
PHPUnit\Framework\Exception: Warning: get_headers(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:400.
/home/travis/build/magento-engcom/import-export-improvements/dev/tests/unit/framework/bootstrap.php:54
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:400
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:376
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:181
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/UploaderTest.php:133
2) Magento\CatalogImportExport\Test\Unit\Model\Import\UploaderTest::testMoveFileUrl with data set #1 ('https://!:^&`;file', '!:^&`;file', 'file')
PHPUnit\Framework\Exception: Warning: get_headers(http://!:^&`;file): failed to open stream: operation failed in /home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:400.
/home/travis/build/magento-engcom/import-export-improvements/dev/tests/unit/framework/bootstrap.php:54
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:400
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:376
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php:181
/home/travis/build/magento-engcom/import-export-improvements/app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/UploaderTest.php:133
Hi @Stepa4man, thank you for your contribution! Please, complete Contribution Survey, it will take less than a minute. Your feedback will help us to improve contribution process.
Fix "no file extension at url" issue
Description (*)
Magento checks headers for content type and takes file extension
Fixed Issues
Manual testing scenarios (*)
Described in issue
Note
Content disposition not used because it's not actually all the time in headers.