magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

Removed method annotation without argument from PHPDoc #152

Closed VoronoyAlexandr closed 5 years ago

VoronoyAlexandr commented 5 years ago

Description

Added argument to PHPDoc annotation @method setRowClickCallback(string $value)

Fixed Issues

#125 Clean Up Magento/ImportExport/Block/Adminhtml/Export/Filter

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php

Contribution checklist (*)

magento-cicd2 commented 5 years ago

CLA assistant check
All committers have signed the CLA.

magento-engcom-team commented 5 years ago

@VoronoyAlexandr thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

dmanners commented 5 years ago

Hi @VoronoyAlexandr thanks for this pull request.

Could you check the static tests.

Magento\Test\Php\LiveCodeTest::testCodeStyle
PHP Code Sniffer detected 2 violation(s): 

FILE: /var/www/html/app/code/Magento/Backend/Block/Widget/Grid.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 152 | ERROR | [x] Missing short description
 153 | ERROR | [x] There must be exactly one blank line before tags
 712 | ERROR | [x] There must be exactly one blank line between lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks

VoronoyAlexandr commented 5 years ago

Good day @dmanners . Done with this errors.