magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

BundleImportExport is missing `selection_can_change_qty` #41

Closed piotrekkaminski closed 6 years ago

piotrekkaminski commented 6 years ago

From @barryvdh on April 21, 2017 13:33

Preconditions

  1. Magento 2.1.6

Steps to reproduce

  1. Create a Bundle product with options.
  2. Export the product, no information about selection_can_change_qty
  3. Import, no possibility to set selection_can_change_qty

image

Expected result

selection_can_change_qty is exported and imported correctly

Actual result

selection_can_change_qty is always true/1

Suggested solution

It seems that while importing, the value is hardcoded: https://github.com/magento/magento2/blob/2.1.6/app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php#L310

I suggest a parameter can_change_qty will be added, while keeping the default on 1 to preserve BC.

'selection_can_change_qty' => (isset($selection['can_change_qty'])) ? ($selection['can_change_qty'] ? 1 : 0) : 1,

The value should also be added to the export of a bundle, to keep import <-> export in sync.

Copied from original issue: magento/magento2#9342

piotrekkaminski commented 6 years ago

From @IlnitskiyArtem on June 30, 2017 15:13

@barryvdh, Thanks for reporting this issue. We've created internal ticket MAGETWO-70390 to address this issue.

piotrekkaminski commented 6 years ago

From @magento-engcom-team on October 4, 2017 9:30

@barryvdh, thank you for your report. We've created internal ticket(s) MAGETWO-70390 to track progress on the issue.

adam-paterson commented 6 years ago

@dmanners Can you assign this one to me please?

dmanners commented 6 years ago

@adam-paterson done, but I think you should have permission to add yourself

adam-paterson commented 6 years ago

Thanks, I tried but wasn’t able to self-assign it.

On 10 Jan 2018, 14:36 +0000, David Manners notifications@github.com, wrote:

@adam-paterson done, but I think you should have permission to add yourself — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.