When updating customers through CustomerImportExport fields thats are not set in importdata will be nullified

[piotrekkaminski]

From @robin31 on February 14, 2017 13:42

When using module-customer-import-export/Model/Import/Customer.php to update existing customers, attributes that are in customer_entity and are not in the data to update will be nullified. For instance, updating customer name and or group through the importer would empty that customers password / rp_roken etc. This happens because in the _saveCustomerEntities function all fields of the customer are passed to insertOnDuplicate function.

Preconditions

1. Magento version 2.1.4

Steps to reproduce

1. Update a existing customer with not all fields specified ie: just email and name or group_id through module-customer-import-export/Model/Import/Customer.php

Expected result

1. Attributes that are not in update data should not be updated

Actual result

1. Attributes that where not in the update data are nullified.

Resolution

In the function call on vendor/magento/module-customer-import-export/Model/Import/Customer.php:264 $this->customerFields should not be passed to the insertOnDuplicate function. The logic of insertOnDuplicate would then automatically build the query for the fields that are actually in the update data.

Query that now is beeging generated when updating customers:(group_id,store_id,created_at,updated_at,entity_id,firstname,lastname,gender,email):

INSERT INTO `customer_entity` (`group_id`,`store_id`,`created_at`,`updated_at`,`entity_id`,`firstname`,`lastname`,`gender`,`email`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?) ON DUPLICATE KEY UPDATE `group_id` = VALUES(`group_id`), `store_id` = VALUES(`store_id`), `updated_at` = VALUES(`updated_at`), `created_at` = VALUES(`created_at`), `created_in` = VALUES(`created_in`), `prefix` = VALUES(`prefix`), `firstname` = VALUES(`firstname`), `middlename` = VALUES(`middlename`), `lastname` = VALUES(`lastname`), `suffix` = VALUES(`suffix`), `dob` = VALUES(`dob`), `password_hash` = VALUES(`password_hash`), `taxvat` = VALUES(`taxvat`), `confirmation` = VALUES(`confirmation`), `gender` = VALUES(`gender`), `rp_token` = VALUES(`rp_token`), `rp_token_created_at` = VALUES(`rp_token_created_at`), `failures_num` = VALUES(`failures_num`), `first_failure` = VALUES(`first_failure`), `lock_expires` = VALUES(`lock_expires`)

Query that should have been generated when updating customersgroup_id,store_id,created_at,updated_at,entity_id,firstname,lastname,gender,email:

INSERT INTO `customer_entity` (`group_id`,`store_id`,`created_at`,`updated_at`,`entity_id`,`firstname`,`lastname`,`gender`,`email`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?) ON DUPLICATE KEY UPDATE `group_id` = VALUES(`group_id`), `store_id` = VALUES(`store_id`), `created_at` = VALUES(`created_at`), `updated_at` = VALUES(`updated_at`), `entity_id` = VALUES(`entity_id`), `firstname` = VALUES(`firstname`), `lastname` = VALUES(`lastname`), `gender` = VALUES(`gender`), `email` = VALUES(`email`)

Copied from original issue: magento/magento2#8548

[piotrekkaminski]

From @magento-engcom-team on October 9, 2017 11:30

@robin31, thank you for your report. We've created internal ticket(s) MAGETWO-81270 to track progress on the issue.

[dmanners]

This has been covered in 2.3-develop by https://github.com/magento/magento2/commit/f06e173d86ee4ee3ed9da5e44f9e05b44b7736f6 and in 2.2-develop by https://github.com/magento/magento2/pull/11968