magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

magento-engcom/import-export-improvements#49 empty value support #73

Closed dmanners closed 6 years ago

dmanners commented 6 years ago

Description

This is the migration of the original PR to the main repository by @RomaKis https://github.com/magento/magento2/pull/11935

Fixed Issues (if relevant)

  1. magento-engcom/import-export-improvements#49 : CatalogImportExport doesn't support empty row values

Manual testing scenarios

  1. Change value to empty for some attribute in csv.
  2. Run product import.
  3. Check this attribute for value. It should be empty.

Contribution checklist

dmanners commented 6 years ago

This PR is migrated from a PR in the main repository. The original PR was good but we would like to discuss with the Import/Export project team as to how the usage of the constant would effect people's usage of the import/export system.

dmanners commented 6 years ago

@ishakhsuvarov would you be able to have a look over this PR as talked about in the previous import/export call. Maybe think about what options we have with regards to development here.

dmanners commented 6 years ago

Ok this will be covered in the PR from @PieterCappelle that can be found at https://github.com/magento/magento2/pull/13472 so as such I will close this PR.

Sorry for any confusion :)