magento-engcom / import-export-improvements

Open Software License 3.0
31 stars 29 forks source link

product images with same name overwrite previous image fix #99

Closed umarch06 closed 6 years ago

umarch06 commented 6 years ago

Description

Images were not being renamed while uploading bulk products with images. For example, while importing images from paths a/b.jpg, b/b.jpg, c/b.jpg for three different products were overwriting the same file b.jpg in magento 2. I allowed to rename file if was already existed in Magento 2 catalog product folder. So there is no overwriting while uploading same image name with different folders.

Manual testing scenarios

  1. Create A CSV File for import by same name image within multi directory
  2. Upload file in pub/media/import directory with directory
  3. Login Backend
  4. Got to setting >> import
  5. Select "Entity Type" Product
  6. Select "Import Behavior" Add/Update
  7. Upload CSV File
  8. Click Button "Check Data "
  9. Click "Import"
  10. Import will be successful and it will not override the existing images file with same names.

Contribution checklist

dmanners commented 6 years ago

Please also take a look at the integration tests for this section of the system.

umarch06 commented 6 years ago

@dmanners, probably I missed seeing the if check, that is fixed in new commit.

magento-engcom-team commented 6 years ago

@umarch06 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.