Update `zendframework/zend-code`

maxbucknell commented 6 years ago

Update zendframework/zend-code to ~3.3.0

Description

As per the issue (magento-engcom/php-7.2-support#93), update the dependency on zendframework/zend-code to ~3.3.0.

Fixed Issues (if relevant)

magento-engcom/php-7.2-support#93: Update zendframework/zend-code

Manual testing scenarios

Shouldn't be any testing required. The site still seems to function normally, but all tests should run to check for regressions.

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

maxbucknell commented 6 years ago

The Travis build came back with some errors in generation. I will review these and see if they are significant, or whether we can just update the tests. (For only whitespace, and other syntactically insignificant changes.)

buskamuza commented 6 years ago

One difference that I observed is a difference in arrays representation: array() vs []

magento-engcom / php-7.2-support