magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

Eliminate usage of Zend_Config from Magento 2 Open Source #71 #103

Closed knowj closed 6 years ago

knowj commented 6 years ago

Remove all references of Zend_Config

Removed all instances/references to Zend_Config within the Magento 2 core. The approach with this is to inherit the docblocks in the files where it still exists.

The complete removal of the project dependency on Zend Framework 1 will require the removal of Zend_Validate which is currently in PR: https://github.com/magento-engcom/php-7.2-support/issues/82

The changes here aren't reflected in issue 82

Description

Remove import of Zend_Config in oAuth keylength validator and inherit previously copy/pasted Docblock Import previously copy/pasted docblock from email address validator

Fixed Issues (if relevant)

  1. magento-engcom/php-7.2-support#71: Eliminate usage of Zend_Config from Magento 2 Open Source #71

Manual testing scenarios

No functionality changed import of Zend_Config was purely for usage in Docblock

Contribution checklist

bbatsche commented 6 years ago

Single build failure in Travis is not related to this change and should be merged anyways