74: Eliminate usage of Zend_Uri from Magento 2 Open Source - Githubissues

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento

Open Software License 3.0

23 stars 26 forks source link

74: Eliminate usage of Zend_Uri from Magento 2 Open Source #104

Closed dcabrejas closed 6 years ago

dcabrejas commented 6 years ago

Description

Replacing usages of Zend_Uri classes with Zend Uri clases from ZF-3.
Removed Zend_Uri typehints that were never used, a common pattern I saw was that the Zend_Uri class was typehinted along with a type string but Magento always passes a string to the method so the Zend_Uri could safely be removed.

Would be good to know how to run static test to make sure 100%.

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All automated tests passed successfully (all builds on Travis CI are green)