search

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

94: Remove Zend_Service Dependency from CurrencyInterface #105

Closed szreka closed 6 years ago

szreka commented 6 years ago

Description

Magento\Framework\CurrencyInterface indicates a dependency on Zend_Service. This is the only dependency on Zend_Service within Magento. Additionally, this dependency is only used to perform currency conversion within an instance of Zend_Currency. This feature is not currently supported or used within Magento, and could be removed safely.

Fixed Issues (if relevant)

magento-engcom/php-7.2-support#94: Remove Zend_Service Dependency from CurrencyInterface

Contribution checklist

buskamuza commented 6 years ago

As this was the last usage of Zend_Service in Magento, it would be good to add a test like https://github.com/magento-engcom/php-7.2-support/pull/102/files#diff-335661b400dfc2da0568abb0cd5cb815 to ensure a dependency doesn't appear again.