magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

Fix Call to undefined function Magento\Ui\Controller\Adminhtml\Index\_() #107

Closed centerax closed 6 years ago

centerax commented 6 years ago

A call on file app/code/Magento/Ui/Controller/Adminhtml/Index/Render.php to the translation logic is using one underscore when the function should be called with two. This breaks test Magento\Ui\Test\Unit\Controller\Adminhtml\Index\RenderTest::testExecuteAjaxRequestException

1) Magento\Ui\Test\Unit\Controller\Adminhtml\Index\RenderTest::testExecuteAjaxRequestException Error: Call to undefined function Magento\Ui\Controller\Adminhtml\Index_()

/var/builds/magento2/app/code/Magento/Ui/Controller/Adminhtml/Index/Render.php:103 /var/builds/magento2/app/code/Magento/Ui/Controller/Adminhtml/AbstractAction.php:62 /var/builds/magento2/app/code/Magento/Ui/Test/Unit/Controller/Adminhtml/Index/RenderTest.php:238

Contribution checklist

centerax commented 6 years ago

not sure if it can be merged as it is @buskamuza because of another failing test.

looking forward to your feedback

bbatsche commented 6 years ago

I think it's safe to say those failure are unrelated to your change; this PR should still be safe to merge

centerax commented 6 years ago

I agree, thanks.