Eliminate usage of Zend_Exception from Magento 2 Open Source - Githubissues

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento

Open Software License 3.0

23 stars 26 forks source link

Eliminate usage of Zend_Exception from Magento 2 Open Source #122

Closed mhauri closed 6 years ago

mhauri commented 6 years ago

Description

Remove the last use of Zend_Exception

Fixed Issues (if relevant)

magento-engcom/php-7.2-support/issues/68: Eliminate usage of Zend_Exception from Magento 2 Open Source

Manual testing scenarios

Not needed, all covered by Travis: https://travis-ci.org/mhauri/php-7.2-support/builds/364521324

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] All automated tests passed successfully (all builds on Travis CI are green)

mhauri commented 6 years ago

@vkublytskyi is it possible to re-run travis as the error seems weird and should not have anything to do with my change. Also here everything was fine: https://travis-ci.org/mhauri/php-7.2-support/builds/364521324

vkublytskyi commented 6 years ago

@mhauri the build is green now. Thank you for your contribution.