magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

Eliminate usage of Zend_Mail from Magento 2 Open Source #136

Open mhauri opened 6 years ago

mhauri commented 6 years ago

Description

Fixed Issues (if relevant)

  1. 72 Eliminate usage of Zend_Mail from Magento 2 Open Source

Contribution checklist

magento-cicd2 commented 6 years ago

CLA assistant check
All committers have signed the CLA.

magento-cicd2 commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mhauri commented 6 years ago

Hi @buskamuza I adapted the test, it seems that ->setMethods(['mockableMethod']) is required to load the mock correctly even when the method doesn't exist and is only for mocking. But I removed all the references to _getMail.

mhauri commented 6 years ago

Hi @buskamuza anything else I can do which helps in processing this PR?