magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 25 forks source link

Failing unit test Magento\Framework\Code\Test\Unit\Generator\InterfaceGeneratorTest #43

Closed buskamuza closed 6 years ago

buskamuza commented 6 years ago
Magento\Framework\Code\Test\Unit\Generator\InterfaceGeneratorTest::testGenerate with data set "Valid data" (array(), '', '')
Interface was generated incorrectly.
Failed asserting that '<?php\n
/**\n
 * Copyright © Magento, Inc. All rights reserved.\n
 * See COPYING.txt for license details.\n
 */\n
\n
/**\n
 * @codingStandardsIgnoreStart\n
 * Coding Standards have to be ignored in this file, as it is just a data source for tests.\n
 */\n
\n
namespace Magento\SomeModule\Model;\n
\n
use Magento\SomeModule\Model\Two\Test as TestTwo;\n
use Magento\SomeModule\Model\Three\Test as TestThree;\n
\n
/**\n
 * Interface short description.\n
 *\n
 * Interface long\n
 * description.\n
 *\n
 * @tag1 data1\n
 * @tag2 data2\n
 */\n
interface SevenInterface extends \Magento\Framework\Code\Generator\CodeGeneratorInterface\n
{\n
\n
    /**\n
     * Method short description\n
     *\n
     * @param array $data\n
     * @return TestThree\n
     */\n
    public static function testMethod1(array &$data = array());\n
\n
    /**\n
     * Method short description\n
     *\n
     * Method long\n
     * description\n
     *\n
     * @param string $data\n
     * @param bool $flag\n
     */\n
    public function testMethod2($data = 'test_default', $flag = true);\n
\n
    public function testMethod3();\n
\n
\n
}\n
' ends with "namespace Magento\SomeModule\Model;
use Magento\SomeModule\Model\Two\Test as TestTwo;
use Magento\SomeModule\Model\Three\Test as TestThree;
/**
 * Interface short description.
 *
 * Interface long
 * description.
 *
 * @tag1 data1
 * @tag2 data2
 */
interface SevenInterface extends \Magento\Framework\Code\Generator\CodeGeneratorInterface
{
    /**
     * Method short description
     *
     * @param array $data
     * @return TestThree
     */
    public static function testMethod1(array &$data = []);
    /**
     * Method short description
     *
     * Method long
     * description
     *
     * @param string $data
     * @param bool $flag
     */
    public function testMethod2($data = 'test_default', $flag = true);
    public function testMethod3();
}
".
/home/travis/build/magento-engcom/php-7.2-support/lib/internal/Magento/Framework/Code/Test/Unit/Generator/InterfaceGeneratorTest.php:96

See https://travis-ci.org/magento-engcom/php-7.2-support/jobs/342577316