search

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 25 forks source link

Eliminate usage of Zend_Service from Magento 2 Open Source #66

Closed vkublytskyi closed 6 years ago

vkublytskyi commented 6 years ago

References count: 1 Used in EE/B2B: no

Acceptance Criteria:

  1. Usage of Zend_Service removed from Magento 2 Open Source
    • all references to Zend_Service are removed from Magento 2 Open Source
    • added static test that verify that Zend_Service is not used
    • Travis builds are green on PHP 7.1 environment
    • all backward incompatible changes are documented (if any)
    • if possible ZF1 component replaced by embedded PHP functionality or PSR interface otherwise migrated to ZF2
    • if ZF1 component replaced by ZF2 component:
      • there is an explanation why it is required to use external dependency
      • if usage of old ZF1 component was exposed in M2 interface/class signatures it is removed for new code
      • there is a list of PHP 7.2 compatibility issues of new ZF2 component OR
  2. There is an explanation why it is impossible to delete this dependency now:
    • described scope of work that is necessary to totally remove usage of Zend_Service
    • described what backward incompatible changes will be caused by dependency removal
    • listed what other ZF1 components are required for Zend_Service to support M2 (if only limited functionality of Zend_Service is used by M2 then not all dependencies may be required and some part of Zend_Service still may be removed if has incompatibility with PHP 7.2)
    • listed PHP 7.2 compatibility issues for Zend_Service
buskamuza commented 6 years ago

Zend_Service usages is eliminated and the library is removed from zf1.