Removed sjparkinson/static-review - Githubissues

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento

Open Software License 3.0

23 stars 26 forks source link

Removed sjparkinson/static-review #84

Closed RomaSlobodeniuk closed 6 years ago

RomaSlobodeniuk commented 6 years ago

Removed sjparkinson/static-review

Description

Removed usage of sjparkinson/static-review in code

Fixed Issues (if relevant)

magento-engcom/php-7.2-support#40: Remove sjparkinson/static-review

Manual testing scenarios

None

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

buskamuza commented 6 years ago

The changes look good. Thanks for the contribution. Would you be able to redo PR into 2.3-develop branch? libs-composer-update is an experimental branch and won't be merged to the mainline soon.

Update: created https://github.com/magento-engcom/php-7.2-support/pull/85