Update to Symfony 4 - Githubissues

pmclain commented 6 years ago

Description

Updates libraries to versions supporting PHP 7.2. This includes the Symfony components and brings composer.lock to a state that allows composer install on PHP ~7.1.3 and ~7.2.0

Fixed Issues (if relevant)

magento-engcom/php-7.2-support#4

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)

buskamuza commented 6 years ago

Confirmed: composer install runs w/o errors on both PHP 7.1 and 7.2

buskamuza commented 6 years ago

Docs needed:

http://devdocs.magento.com/guides/v2.3/architecture/arch-basics.html and related articles

@shrielenee, could you please help with this? See updated PHP versions https://github.com/magento-engcom/php-7.2-support/pull/86/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R15

pmclain commented 6 years ago

@buskamuza The requested changes have been made. I also updated .travis.yml, replacing php 7.0 with 7.2.

buskamuza commented 6 years ago

Waiting for PRs to internal repositories before this one can be merged.

magento-engcom / php-7.2-support

Update to Symfony 4 #86

Description

Fixed Issues (if relevant)

Contribution checklist