search

magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

Remove Zend_Service Dependency from CurrencyInterface #94

Closed bbatsche closed 6 years ago

bbatsche commented 6 years ago

Magento\Framework\CurrencyInterface indicates a dependency on Zend_Service. This is the only dependency on Zend_Service within Magento. Additionally, this dependency is only used to perform currency conversion within an instance of Zend_Currency. This feature is not currently supported or used within Magento, and could be removed safely.

  1. Remove getService() method from CurrencyInterface
  2. Remove setService() method from CurrencyInterface