magento-engcom / php-7.2-support

Repository for implementing support of php-7.2 support in Magento
Open Software License 3.0
23 stars 26 forks source link

Fix Calls to count() #97

Closed bbatsche closed 6 years ago

bbatsche commented 6 years ago

Description

Add logic and checks to avoid passing null to count() and make sure that any classes with a public count() method implement Countable interface.

Fixed Issues (if relevant)

  1. magento-engcom/php-7.2-support#7: Warning: count(): Parameter must be an array or an object that implements Countable

Contribution checklist

buskamuza commented 6 years ago

There are still failures with count(). See: