fixed agreements filter

magento-hackathon / AdvancedAcl

43 stars 12 forks source link

Closed sprankhub closed 7 years ago

sprankhub commented 7 years ago

In the current version, the agreements were not filtered correctly. The new version does the following:

If the user has been given access to "All Store Views", no filter will be applied.
If there is no store view set at all, no filter will be applied.
If one or multiple store views are selected, the collection will be filtered accordingly. It is important to set the _isStoreFilterWithAdmin flag then. The comment "collection allows only filter by ONE store" is wrong.

quafzi commented 7 years ago

Hmm, Travis tests fail, but you seem to be innocent…

luemic commented 7 years ago

Looks like the magento setup is failing on travis, see also https://github.com/AOEpeople/MageTestStand/issues/11