search

magento-hackathon / AdvancedAcl

43 stars 12 forks source link

Fixed Issue That "All Store Views" Option Did Not Work #23

Closed sprankhub closed 7 years ago

sprankhub commented 7 years ago

Previously, the store views field was required when editing an admin role. If you selected "All Store Views", the user should see all orders/invoices/etc. Unfortunately, the user did not see any of them, because the filter was applied to the collection with a store_id of 0. Hence, I made the field optional and hided the "All Store Views" option. If you do not select any store view, no filter is applied. This is also what the README says:

If none is selected, the role access won't get limited.
sprankhub commented 7 years ago

Any issues with this PR? ;-)

therouv commented 7 years ago

Ping @luemic @andreaspenz :-)

luemic commented 7 years ago

Sorry guys, I'll have a look on it until the end of the week :)