search

magento-hackathon / HoneySpam

Spam protection module for customer registration, product review form and contact form.
Open Software License 3.0
102 stars 36 forks source link

Duplicate field error when you use in the Newsletter subscription #41

Closed vishy93 closed 6 years ago

vishy93 commented 6 years ago

Using this in the Newsletter subscription will cause the error:

[DOM] Found 2 elements with non-unique id #url error

Therefore, wouldn't it be appropriate to remove the id declaration?

It is not being used anywhere, and would help prevent his error!

sprankhub commented 6 years ago

This is indeed an issue. @Schrank said that it is more likely that the field is filled by bots if it has an attibute id="url". Not sure if it would work without it. I guess most of the bots would fill it anyway. Could you remove it and give us feedback whether it still works @vishy93?

vishy93 commented 6 years ago

@sprankhub Removing the id caused no issue and works fine for me. I shall do more testing, and see if I can look into the robot side. Will keep you posted.

vishy93 commented 6 years ago

Looking into further I could find no evidence to suggest having an id in the field would cause greater filling in by bots.

sprankhub commented 6 years ago

Thanks for your feedback @vishy93! I would still love to hear something from @Schrank. If he thinks this is OK, I am fine with removing the id attribute.

vishy93 commented 6 years ago

No worries @sprankhub :)

Schrank commented 6 years ago

LEt'S remove it.