search

magento-hackathon / Perfect_Watermarks

A replacement for Magento's GD2 image adapter with imagemagick
Open Software License 3.0
53 stars 28 forks source link

CYMK to RGB Conversion won't work when Magento Compiler is on #16

Open jasperthedummy opened 9 years ago

jasperthedummy commented 9 years ago

Pull request #14 (@rbrown) introduced support for CYMK images by converting them to RGB so that an image resize will not cause an image to become inverted in color. However, it doesn't work for sites using the Magento compiler, because the use of __DIR__ magic constant will point to [magento_root]/includes/src, instead of where the ICC profiles currently live [magento_root]/app/code/community/Varien/Image/Adapter/. The resulting resized image will still be inverted in color.

Suggestion to put the ICC files in [magento_root]/lib/FireGento/PerfectWatermarks/.

Schrank commented 9 years ago

Afaik there is no advantage in using a compiler. But this is not my project, so I have no opinion in this.

jasperthedummy commented 9 years ago

I know many sites that are using the compiler, and many sites that don't. Just trying to make it compatible with everyone no matter what benefits the compiler may bring. Besides, /lib/ seems to be a more appropriate place to store external libraries.

Submitted a PR #17.