Fix resize (supports keepFrame and bicubic interpolation)

magento-hackathon / Perfect_Watermarks

A replacement for Magento's GD2 image adapter with imagemagick

Open Software License 3.0

53 stars 28 forks source link

Fix resize (supports keepFrame and bicubic interpolation) #3

Closed colinmollenhour closed 11 years ago

colinmollenhour commented 11 years ago

I believe this fixes all of the issues I had previously with keepFrame. Also the way it composites the image over a solid background color should be much faster that the nested loop that you were using before. Note I haven't tested it with backgroundColor as on my system everything is just white.

colinmollenhour commented 11 years ago

Actually I just noticed you didn't use a nested loop.. I must have seen that somewhere else..

datenbrille commented 11 years ago

Hey Colin,

sorry for the delay. I will close the this pull request and I will build a new release with your changes. Furthermore I will add some instructions to get the project straight for further development. You dropped in a very early stage.

Best Regards

Karl

colinmollenhour commented 11 years ago

No prob. Thanks for sharing your work!