search

magento-hackathon / Responsive-Email-Templates-with-CSS-Inliner

Idea from Kalen Jordan. We can take http://zurb.com/ink/ as a base.
https://github.com/orgs/magento-hackathon
31 stars 10 forks source link

Recursion #5

Closed thaiphan closed 8 years ago

thaiphan commented 10 years ago

I noticed that Hackathon_ResponsiveEmail_Model_Email_Template extends Hackathon_ResponsiveEmail_Model_Email_Template_Abstract which can also potentially extend Hackathon_ResponsiveEmail_Model_Email_Template. Just a heads up!

kalenjordan commented 10 years ago

Oops! You should be able to safely just remove lines 7 and 8: https://github.com/magento-hackathon/Responsive-Email-Templates-with-CSS-Inliner/blob/master/app/code/community/Hackathon/ResponsiveEmail/Model/Email/Template/Abstract.php#L7

I think I didn't catch that b/c I have the other modules installed in my test environment. Also I'm not really actively using this - I merged this code into another project that I've been working on - but feel free to make any modifications / PRs that you'd like to.