search

magento-hackathon / Simple-Image-Helper

Magento's image helper is bloated and the performance impact is quite significant. Some of the complexity can also be removed because the gain is not that significant (example: the hash part of the image url). I would like to be able to use a replacement with the following features: - lightweight - support for gd and imagemagick - has nicer image paths Optional: - use a queueing system for the resize job If others are interested we can spec this out further. Update by Admin: https://github.com/magento-hackathon/Perfect_Watermarks https://github.com/monsieurbiz/Mbiz_ImageCrop
https://github.com/orgs/magento-hackathon
32 stars 5 forks source link

Add composer.json #12

Closed mbijnsdorp closed 10 years ago

Flyingmana commented 10 years ago

I dont think so, it has no dependencies to composer packages, and uses the usual magento directory structure

jamescowie commented 10 years ago

If we are going to use composer to install the module then we need to add the extra paths to the composer.json

"require" : {
   "magento-hackathon/magento-composer-installer":"*"
},
    "extra" : {
        "map": [
            ["app/etc/modules/..." , "app/etc/modules/..."],
         ]
    },
Flyingmana commented 10 years ago

no, having the modman file is enough

jamescowie commented 10 years ago

I agree if the module is not requiring any other dependencies and is not using composer to install the module then we do not need this PR. I prefer composer over modman but that is because in other modules I do at times require other dependencies but as this module doesn't I see no value in adding more complexity and having 2 methods of installing a module that we need to maintain.

As such I will close this down unless anyone sees a valid reason to re open.