search

magento-hackathon / Simple-Image-Helper

Magento's image helper is bloated and the performance impact is quite significant. Some of the complexity can also be removed because the gain is not that significant (example: the hash part of the image url). I would like to be able to use a replacement with the following features: - lightweight - support for gd and imagemagick - has nicer image paths Optional: - use a queueing system for the resize job If others are interested we can spec this out further. Update by Admin: https://github.com/magento-hackathon/Perfect_Watermarks https://github.com/monsieurbiz/Mbiz_ImageCrop
https://github.com/orgs/magento-hackathon
32 stars 5 forks source link

Image helper models #9

Closed jamescowie closed 10 years ago

jamescowie commented 10 years ago

Created the models and base table required for the module.

jamescowie commented 10 years ago

I have updated the models to use Resource and not refer to MySQL4. Next up is the DDL

jamescowie commented 10 years ago

I have updated the installer to be valid DDL and should work on any DB installation now.

jamescowie commented 10 years ago

The cron now invokes the process to generate image assets not the observer.

rgranadino commented 10 years ago

Are there any issues with leaving the model group names prefixed with hackathon_?

jamescowie commented 10 years ago

Hello, Im happy either way. I went with simpleimage for simplicity although on reflection it does loose context for module name. Happy to revert back if people prefer ? Ideally I would like to get this PR merged so we can start to look at what is required to get to a stable POC

rgranadino commented 10 years ago

I'd say revert it back so that's its consistent with the helper group name.

I didn't get a chance to test out your changed but does the created at/updated at value in the DB get auto populated? I think we can get by with just a single date column since the rows are deleted once processed. This column could have a default value of now() so there's no need to have any _beforeSave() logic to check if the model is new.

jamescowie commented 10 years ago

Hi All,

I have refactored the model entities to now use hackathon_simpleimage/simpleimage I also refactored the crontab model as it was not easily readable.