search

magento-hackathon / m2-content-provisioning

Configure CMS (pages or block) entries via XML and define how them should be deployed.
MIT License
45 stars 19 forks source link

Bug: Installation in Magento 2.2 not possible #17

Closed vadimjustus closed 5 years ago

vadimjustus commented 5 years ago

Installation in Magento 2.2 not possible Currently it is not possible to install the module in Magento 2.1 and Magento 2.2, since composer dependency for magento/framework requires version 102.0.*.

To Reproduce

  1. composer create-project --repository=https://repo.magento.com/ magento/project-community-edition magento-22 2.2.8
  2. cd magento-22
  3. composer require firegento/magento2-content-provisioning

Error Log

Using version ^1.2 for firegento/magento2-content-provisioning
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install composer/composer 1.8.4
    - Conclusion: don't install composer/composer 1.8.3
    - Conclusion: don't install composer/composer 1.8.2
    - Conclusion: don't install composer/composer 1.8.1
    - Conclusion: don't install composer/composer 1.8.0
    - Conclusion: don't install composer/composer 1.7.3
    - Conclusion: don't install composer/composer 1.7.2
    - Conclusion: don't install composer/composer 1.7.1
    - Conclusion: don't install composer/composer 1.7.0
    - Conclusion: don't install composer/composer 1.7.0-RC
    - Conclusion: don't install composer/composer 1.6.5
    - Conclusion: don't install composer/composer 1.6.4
    - Conclusion: don't install composer/composer 1.6.3
    - Conclusion: don't install composer/composer 1.6.2
    - Conclusion: don't install composer/composer 1.6.1
    - Conclusion: don't install composer/composer 1.6.0
    - Installation request for firegento/magento2-content-provisioning ^1.2 -> satisfiable by firegento/magento2-content-provisioning[1.2.0].
    - Installation request for magento/product-community-edition 2.2.8 -> satisfiable by magento/product-community-edition[2.2.8].
    - firegento/magento2-content-provisioning 1.2.0 requires magento/framework 102.0.* -> satisfiable by magento/framework[102.0.0, 102.0.1].
    - magento/framework 102.0.1 requires composer/composer ^1.6 -> satisfiable by composer/composer[1.6.0, 1.6.0-RC, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7.0, 1.7.0-RC, 1.7.1, 1.7.2, 1.7.3, 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4].
    - magento/framework 102.0.0 requires composer/composer ^1.6 -> satisfiable by composer/composer[1.6.0, 1.6.0-RC, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7.0, 1.7.0-RC, 1.7.1, 1.7.2, 1.7.3, 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4].
    - Conclusion: don't install composer/composer 1.6.0-RC

Installation failed, reverting ./composer.json to its original content.
vadimjustus commented 5 years ago

There is still an issue with installing the module in Magento 2.1 and 2.2 since code generation for this versions does not support return types.

Fehler: PHP Fatal error:  Declaration of Firegento\ContentProvisioning\Model\Query\GetPageEntryList\Proxy::get() must be compatible with Firegento\ContentProvisioning\Model\Query\GetPageEntryList::get(): array in /Volumes/Workspace/eglo/src/generated/code/Firegento/ContentProvisioning/Model/Query/GetPageEntryList/Proxy.php on line 7

Thank you @baumgartners for reporting this issue

vadimjustus commented 5 years ago

Installation works now. Magento version >= 2.2.7 is supported. Lower versions has problems with code generation and return types.