magento-hackathon / m2-content-provisioning

Configure CMS (pages or block) entries via XML and define how them should be deployed.
MIT License
45 stars 19 forks source link

Refactoring: Duplicate code #6

Open vadimjustus opened 5 years ago

vadimjustus commented 5 years ago

Current Problem Following the current programming standards of Magento (see https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html), causes some duplicate code. E.g. the class \Firegento\ContentProvisioning\Model\Command\ApplyPageEntry is pretty similar to \Firegento\ContentProvisioning\Model\Command\ApplyBlockEntry.

TODO An solution must be found, how to bring in the required functionality and following the technical guidelines.