search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Newest version breaks on composer update #117

Closed mpaepper closed 9 years ago

mpaepper commented 10 years ago

PHP Fatal error: Interface 'Composer\Plugin\PluginInterface' not found in /var/www/vhosts/domain.com/httpdocs/vendor/magento-hackathon/magento-composer-installer/src/MagentoHackathon/Composer/Magento/InstallerPlugin.php on line 10

The file InstallerPlugin is not in the repo?

Flyingmana commented 10 years ago

which version of the installer do you have installed?

are you sure its 2.0.0?

mpaepper commented 10 years ago

I just ran composer update, it installed a new version and then created that error message. Would composer update normally install 2.0.0?

bragento commented 10 years ago

Did you noticed https://github.com/magento-hackathon/magento-composer-installer#known-issues already?

Flyingmana commented 10 years ago

could you please execute composer.phar licenses? this lists also the versions of the installed packages.

mpaepper commented 10 years ago

composer.phar licenses yields "Command licenses is not defined."

Flyingmana commented 10 years ago

then it seem you do not use the most current version of composer. Did try it with the newest one: Composer version 745dcbce3317f7119575c39cef2cb601f9c5ffcf 2014-06-29 16:49:45

mpaepper commented 10 years ago

Yes, I needed to Run the self update and then the fix @bragento mentioned.

It is Bad though, that it breaks older versions. Any ideas how we could prevent this or at least Show a massage of how to proceed?

Thanks! Am 01.07.2014 09:52 schrieb "Daniel Fahlke" notifications@github.com:

then it seem you do not use the most current version of composer. Did try it with the newest one: Composer version 745dcbce3317f7119575c39cef2cb601f9c5ffcf 2014-06-29 16:49:45

— Reply to this email directly or view it on GitHub https://github.com/magento-hackathon/magento-composer-installer/issues/117#issuecomment-47627020 .

davidverholen commented 10 years ago

i'm pretty sure its a bug in the composer plugin api.

it seems like the updated plugin is executed without auto/reloading the classes from the new plugin

Flyingmana commented 10 years ago

not exactly a bug, but a limitation we need to face, and Iam not sure if there is a sane way to workaround this with things like reflection.

anyway, as this got solved trough a composer self-update, there is no priority, as composer has not a stable release yet and people should update regularly anyway

tkdb commented 10 years ago

Yesterday I did an install which also included that magento composer installer update to v2 and I had no such problem (just the known one: #107 which was expected).

I did run the self-update earlier IIRC.

Flyingmana commented 9 years ago

I close this issue. The composer team recommends to do plugin/installer updates only together with --no-plugins/--no-custom-installers argument, so this issue is in the recommended way of usage not existent.