magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Module uninstall does not update .gitignore #125

Open vernard opened 9 years ago

vernard commented 9 years ago

I set auto-append-gitignore to true and the .gitignore updates after installing a module.

However when I remove a module, it doesn't remove the deleted contents of the module.

Scenario:

Here's my composer.json:

    "require": {
        "vendor/custom-module": "*",
        "magento-hackathon/magento-composer-installer": "*"
    }
    "extra": {
        "auto-append-gitignore": true,
        "magento-root-dir": "htdocs",
    }

Considering that custom-module is a valid magento-module, it will be installed with symlinks and the .gitignore will have the symlinked files ignored.

Then I remove the custom module. and having this composer.json:

    "require": {
        "magento-hackathon/magento-composer-installer": "*"
    }
    "extra": {
        "auto-append-gitignore": true,
        "magento-root-dir": "htdocs",
    }

And run composer update.

.gitignore still ignores the files of the custom-module.