magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Modules not deleted in .modman folder after removing it in composer #126

Closed vernard closed 9 years ago

vernard commented 9 years ago

Hi,

I have the following composer.json:

    "require": {
        "vendor/custom-module": "*",
        "magento-hackathon/magento-composer-installer": "*"
    },
    "extra": {
        "modman-root-dir": ".modman",
        "magento-root-dir": "htdocs"
    }

I have this directory structure:

/MagentoProject
    /.modman/
    /composer.json
    /htdocs/
    /vendor/

Assuming that vendor/custom-module is a valid magento module, it will be put in .modman directory after a composer install.

My .modman directory will now have the following contents:

/.modman
    /.basedir
    /custom-module/

Then after I remove my custom-module from composer, I will have this composer.json:

    "require": {
        "magento-hackathon/magento-composer-installer": "*"
    },
    "extra": {
        "modman-root-dir": ".modman",
        "magento-root-dir": "htdocs"
    }

Then run composer update.

I'm expecting that the /.modman/custom-module/ directory will be deleted, but it was not.

vernard commented 9 years ago

The symlinks are not removed as well.

By the way, I'm running on Windows 7

Flyingmana commented 9 years ago

I hope @Vinai or @fbrnc can look into this, as they were responsible for the support of the .modman directory

Flyingmana commented 9 years ago

feature will be removed in 3.0

sorry for the inconvenience

vernard commented 9 years ago

You mean modman will not be supported anymore?

Flyingmana commented 9 years ago

at least the storage inside the .modman folder, the modman mapping will still be supported

vernard commented 9 years ago

So the mapping will be from %MAGENTO_ROOT%\vendor\company\module\ to %MAGENTO_ROOT%\?

Flyingmana commented 9 years ago

if you have magento-root as "./" in composer.json then yes

vernard commented 9 years ago

That's good news.We use this structure as well, but we're using another program to do the mapping. Can't wait to see 3.0.

Cheers!