Revert "Fix "Could not delete" Exception on removeDirectory"

tkdb commented 9 years ago

This reverts commit b8ccfdfd81439f41396ec8d0b28d7f43e7d6a25e.

It is not necessary any longer.

It was a fix for a problem reported in #122.

Which has fixed upstream in composer as it was a problem there.

tkdb commented 9 years ago

@Flyingmana Good news! The upstream changes in composer were accepted:

The hotfix code in https://github.com/magento-hackathon/magento-composer-installer/commit/b8ccfdfd81439f41396ec8d0b28d7f43e7d6a25e can be removed then.

For an install where b8ccfd was not applied and with the old composer I still get the RuntimeException:

$ composer remove "firegento/logger"
Warning: This development build of composer is over 30 days old. It is recommended to update it by running "/[...]/composer.phar self-update" to get the latest version.
Loading composer repositories with package information                                                                                                                                 Updating dependencies (including require-dev)         

  [RuntimeException]
  Could not delete /[...]/magento/app/code/community/FireGento/Logger/:

However after updating composer to the current version, I don't have this problem any longer for removing the dependency.

So as expected the changes upstream have fixed the issue. +1

See #122

Flyingmana commented 9 years ago

:+1:

magento-hackathon / magento-composer-installer

Revert "Fix "Could not delete" Exception on removeDirectory" #131