magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Possible (dangerous) typo in Core deploy strategy #137

Closed myovchev closed 9 years ago

myovchev commented 9 years ago

I didn't dig deep enough, but my simple logic says beforeClean() in src / MagentoHackathon / Composer / Magento / Deploystrategy / Core.php (on line 66) should call parent::beforeClean() and not parent::beforeDeploy()

davidverholen commented 9 years ago

oh, yes that's totally right