search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Review implementation and tests of joinPath in MagentoInstallerAbstract #146

Closed Flyingmana closed 9 years ago

Flyingmana commented 9 years ago

especially the explode part (possible wrong argument order)

davidverholen commented 9 years ago

not only possible, that's totally wrong. I'll make a pr with a new function, that uses preg split to divide the items (at \ and /) and then implodes them with the directory separator.