Closed AydinHassan closed 9 years ago
What does your installer do exactly? Of course you are very welcome to contribute whatever advantages you might have built into your installer.
Anyhow we'll put this issue up for internal discussion and consider adding an optional flag.
I don't really know what the core installer for this project does tbh. I just wanted a more concise solution, we have no need for the modman support and some of the other the stuff more advanced stuff. Including permission management, local xml creation and so on. We don't use mappings for the core (not sure if you do here or not). Also I wanted it to be unattended as we use in production deploys.
It is here anyway: https://github.com/AydinHassan/magento-core-composer-installer
Thanks for looking into this, I will fork for now.
if you just want specific files to be unattended, you might want to take a look at https://github.com/bragento/bragento-composer-installer
The Core Installer is completely reworked and you can define files that will be backed up between core deployments.
By now it's still missing some functions like autoappend gitignore, but they will be added soon. We are also working on a release mechanism for most secure production deployments
Thanks, but ours is more suited to our needs. I just want to use this project for only modules. so would be cool to disable the core installer. I can PR - should I just add an option to the ProjectConfig
class and wrap https://github.com/magento-hackathon/magento-composer-installer/blob/master/src/MagentoHackathon/Composer/Magento/Plugin.php#L143 with an if statement?
that should do the trick, But I think you should also disable the deployManagerCore at https://github.com/magento-hackathon/magento-composer-installer/blob/master/src/MagentoHackathon/Composer/Magento/Plugin.php#L184
@AydinHassan you can you still add an Issue for the 3.x problems? Its still marked as alpha, as I expected problems, but dont have enough tester to find them
@Flyingmana I will have a proper look into it soon and provide a proper issue or possible solution
Is it possible to do this?
We have our own composer plugin to deal with core-packages, so we are conflicting with this package. We want to just use this package for our module deploys.
If not is it worth PR'ing? I see it seems the core installer is removed in the 3.x branch. Is that likely to be finished off soon? I did try to use that instead but I couldn't get it to work (symlinks weren't created correctly), I just left it to the fact its alpha.
I guess that gives me two options:
Thanks!