search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 156 forks source link

Updating magento removes installed modules modules #157

Open ihor-sviziev opened 9 years ago

ihor-sviziev commented 9 years ago

Steps to reproduce:

  1. Install magento 1.8 via composer
  2. Install few modules via composer
  3. Change magento version to 1.9.1.0
  4. Make composer update

Actual result: We have installed magento 1.9.1.0 without already installed modules

Expected result: We have installed Magento 1.9.1.0 with all already installed modules

Flyingmana commented 9 years ago

could you describe which way you use to update/install the magento versions? there are several, but not every way works good.

davidverholen commented 9 years ago

it happens because the modules are only deployed on install or update. The magento core update overwrites the directories.

There are different possible ways to fix this which are just not implemented by now.

The easiest workaround currently is to also install the magento-hackathon/composer-command-integrator and execute 

vendor/bin/composerCommandIntegrator.php magento-module-deploy

To fix this behavior either modules have to be automatically redeployed after core update or the deploy strategy for the core has to be changed to resolve all directories down to the files and deploy only files and not overwrite directories

ihor-sviziev commented 9 years ago

@davidverholen :+1: modules should be automatically re-deployed after mage/core update

davidverholen commented 9 years ago

in my agency we currently use a custom plugin that executes the DeployCommand at the end because we had the same Problem.

Also, since only packages are deployed that are updated or installed, when the composer command crashes after it installed 2 or 3 modules and then is restarted, those 2 or 3 modules are skipped by the composer and so also by the DeployManager. In this case it is also good to have everything redeployed.