search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Remove unused $persistentDirs #183

Closed barryvdh closed 9 years ago

barryvdh commented 9 years ago

I don't think this is used, or am I overlooking something? It is used here: https://github.com/magento-hackathon/magento-composer-installer/blob/a0765d8466a22db662668c999c7cc4576e242c80/src/MagentoHackathon/Composer/Magento/Deploystrategy/Core.php#L130-L140 but that has it's own variable, so this might be confusing.

Flyingmana commented 9 years ago

The whole class is not existent anymore in the 3.x branch, but for the functionality of the core installer they seem to be important, maybe the correct fix for the 2.x versions would be to implement the usage of it then.