Avoid installing magento-core in modman folder.

[nocturnalfrog]

When using a specific modman-root-dir the magento-core package would be installed inside the modman directory.

Config:

    "extra":{
        "magento-root-dir": "htdocs/",
        "modman-root-dir": "htdocs/.modman"
    }

Result of using the wrong installation path:

htdocs/
├── .htaccess
├── .modman
│   └── core
│       ├── .htaccess
│       ├── .htaccess.sample
│       ├── LICENSE.html
│       ├── LICENSE.txt
│       ├── LICENSE_AFL.txt
│       ├── RELEASE_NOTES.txt
│       ├── api.php
│       ├── app
│       ├── composer.json
│       ├── cron.php
│       ├── ...
├── app
│   ├── .htaccess
│   ├── Mage.php
│   ├── code
│   │   ├── community
│   │   └── core
│   ├── design
│   │   ├── adminhtml
│   │   ├── frontend
│   │   └── install
│   ├── ...

After applying this pull request the magento-core package is installed in the vendor directory while the magento-modules are still installed in the modman-root-dir.

[Flyingmana]

it seems you broke the travis build, will look again into it after you fixed this.

A hint, the modman dir feature will get removed in version 3.x, so you should make sure your require statements dont update automatically to it when released.

[barryvdh]

Travis build was already broken, see #185

[Flyingmana]

@barryvdh but the errors are unrelated to #185 it seems

[barryvdh]

The first commit errors on the the same things as #185 fixes, otherwise no errors.

The 2nd commit adds some weird var_dump calls, which causes more errors. Not sure why @nocturnalfrog did that. Reverting the 2nd commit and running the tests should probably fix it.

Not sure if the PR is correct or anything by the way ;)

[nocturnalfrog]

@barryvdh: Sorry about the confusion with the second commit, I wasn't aware that GitHub provided support for follow-up commits. (That'll teach me to use a topic branch in the future! :stuck_out_tongue_closed_eyes:) I've reverted the second commit. The Travis build seems to have succeeded now.

@Flyingmana: Could you elaborate some more on the modman dir feature disappearing as of version 3.0? What was the motivation behind this decision and is there an alternative recommended way of working?

[Flyingmana]

@nocturnalfrog thank you, will merge now :)

the modman dir feature had 3 problems.

• no documentation how it should work
• not a single test to verify what it should do
• I was not able to reach one of the 2 persons who initially implemented it

I can see what an alternative could be, when you describe the problem you are trying to solve with it. You can contact me per mail to discuss a solution suitable for your use case.