issues
search
magento-hackathon
/
magento-composer-installer
Composer installer for Magento modules
210
stars
154
forks
source link
Rewrite cross-platform symlink logic
#190
Closed
HenningCash
closed
9 years ago
HenningCash
commented
9 years ago
180 broke symlink creation on windows so i decided to rewrite the part completly.
As mentioned somewhere in the PR let's use
symlink()
for both windows and unix so no need for escaping, etc
The
_symlink()
method was missing a return statement for symlink creation state so we can also drop the redundant check afterwards with
readlink()
.
Flyingmana
commented
9 years ago
thank you very much
180 broke symlink creation on windows so i decided to rewrite the part completly.
symlink()
for both windows and unix so no need for escaping, etc_symlink()
method was missing a return statement for symlink creation state so we can also drop the redundant check afterwards withreadlink()
.