Closed joshribakoff closed 10 years ago
Nope, there is no secret step. composer pulls the module, reads the modman file and creates the links
ok FYI it didn't work for me. modman clone creates the symlinks, so therefore my modman file is valid.
composer install drops my module into the vendor file, but did not create the symlinks.
Therefore, assuming there is no secret step to tell it to use a modman file, it appears to be a bug to me (or if not, I'm just unclear on its usage and therefore it could benefit from better documentation/examples)
FYI here's the composer.json from my module:
{
"repositories": [
{
"type": "composer",
"url": "http://packages.firegento.com"
}
],
"name": "***/****",
"require": {
"magento-hackathon/magento-composer-installer": "dev-master"
},
"extra":{
"magento-root-dir": "."
}
}
When I require it from the host project (Magento), composer installs the magento-composer-installer
and my module (complete with its tested & working modman file), there is not output about creating or failing to create any symlinks, and no symlinks are present.
I also put the "magento-root-dir" & setup the firegento repo in my host project's composer.json
Ok, the other way around: what happens? Are the files copied, hard linkes, whatever? or only downloaded and don't appear in the magento directory? try another module, like: firegento/magesetup
magesetup installed fine w/ symlinks. What do you mean other way around? And no, with my module it didnt create any symlinks or copy any files (other than to the vendor folder). Comparing my stuff to yours, I'm missing "type":"magento-module"... also, I used one tab in the modman file instead of two.. Could be more difference I'm not seeing. I'm guessing there's a good change "type": "magento-module" is the required step I missed?
On a related note - why make it Magento specific?
the type
says the installer to process the module, so YES, this is important! :)
Ok I changed that & confirmed it installs the symlinks for my module (although it did so silently - it would be nice to see some output saying what its doing)
Also is there anything about this project thats Magento specific? I'm creating my own shopping cart on the weekends & thinking about using it for that. Should I fork it, or would you be willing to rename the parts that say "Magento" (the "type", and project name, etc..)
more detailed output is given, when you use the composer option for more detailed output ( -v -vv or -vvv )
The project structure and the modman file are magento specific developments. I dont recomment it for non magento projects because of future changes on the magento-installer.
Depending on what you need, I recommend to read the composer dokumentation for installers and plugins.
Can I close this issue, as the original issue is not an issue anymore?
Yes thanks!
I have a modman file & modman created symlinks fine. I deleted the symlinks modman created and then ran your tool, it did not create ANY symlinks. I guess there's some secret steps to tell it to use the modman file?