search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

auto-append-gitignore not working #81

Closed yellowmamba closed 10 years ago

yellowmamba commented 10 years ago

I've raised this issue in #34 but couldn't get that reopened, so created a new issue here.

I tried changing .gitignore file permissions to 777, but still nothing has been written to this file. Even if I deleted the existing file, this directive won't create a new file.

AydinHassan commented 10 years ago

I'll take a look when I get some time, but it does work for me. Do the tests run successfully?

yellowmamba commented 10 years ago

Yeah, the tests are all through.

AydinHassan commented 10 years ago

I'm not sure why it doesn't work for you, the code in the master branch is different to my branch, It must have been edited on merge. I am still current using my fork which works for me.

yellowmamba commented 10 years ago

Could you pull down the latest from master and see if that still works for you?

Flyingmana commented 10 years ago

I did some changes on the implementations, mostly because of running the unittests did break the .gitignore of this repository :D

So I changed the tests to use the virtual paths we already use for testing and also moved the position into the target magento directory.

So could you look into the target directory and see if the file gets generated there?

yellowmamba commented 10 years ago

Excellent! Could you also make a minor release for that? Otherwise you'll have to use dev-master in composer.json file for this repo. * only fetches the latest release/tag.

Flyingmana commented 10 years ago

it will be a major release, as i did change a lot of things and have at least one BC break. first release candidate (2.0.0-rc1) comes tomorrow (so you will still need to mark it as "@dev" or similar, Need to test myself how this works^^)

I plan a stable release in one or two weeks, depending on the responses and if people find problems or bugs.

yellowmamba commented 10 years ago

Cheers! Thank you for your help!